search

eclipse-kuksa / kuksa-android-companion

Apache License 2.0
3 stars 1 forks source link

Improve Design of Settings Screen #56

Closed wba2hi closed 6 months ago

wba2hi commented 6 months ago

Is your feature request related to a problem? Please describe. "Dialog" Buttons for "Cancel" and "OK" might get cut off, if trying to change the port in landscape mode.

Describe the solution you'd like A more sophisticated and general solution for the settings should be chosen to update the settings. Right now depending on the position in the list the buttons may be cut off. Showing a real modal dialog which is centered to the screen might make more sense. Or switch the "TextViews" with "EditTexts".

Additional context

wba2hi commented 6 months ago

See Screenshot:

MicrosoftTeams-image
SebastianSchildt commented 6 months ago

Don't want to request additional Features, but this "Connected" bar might be more... delicate...

maybe just a small indication on top of the buttons or something?

wba2hi commented 6 months ago

Don't want to request additional Features, but [...]

Please do request whenever you have something in mind or let's discuss about additional features

... this "Connected" bar might be more... delicate...

The text being to far on the left side is only due to bad cropping of the image when copy & pasting it or do you think it's to big and would just like to have something more subtle?
In the SDK we added the following icons to demonstrate the dis-/connected state: grafik

Are these more to your liking?

However I'm unsure if the icons would be positioned in the NavigationBar. As people have the expectation to be navigated somewhere and not to "do something in the background". We probably also need to figure something out about to show a "loading / connecting" animation while trying to connect after clicking on it while offline.

SebastianSchildt commented 6 months ago

Cropping was an issue but generally I think it is quite "in your face". If you are disconnected, certainly you need a clear indicator. For connected it is the question if that much screen estate should be used for this kind of static "Everything is working as expected" information.

But I think, that is maybe nothing related specifically to this ticket (because it was the same in portrait, just less noticeable).

And the answer seems not obvoius/easy. As you said if it is in the toolbar, it is not good of the visual style is the same as for a button.

In the Tesla App, although I think that is not easy/possible to replicate for us, while not connected the 3D avatar of the car is a transparent silhouette.

IMG_93D5C8434147-1

Just for brainstorming as we already established we are beyond scope for this PR 😄