search

eclipse-kuksa / kuksa-can-provider

Apache License 2.0
3 stars 10 forks source link

Implement support for CAN-FD and container frames #6

Closed andlaus closed 8 months ago

andlaus commented 8 months ago

this is a direct carryover of the same PR from the old repository. All discussions for the original PR still apply.

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information

erikbosch commented 8 months ago

Thanks for moving the PR. The eclipsefdn/eca check fails, in one of your commits alwalz1@cmtclmlvxqr6x4k.rd.corpintra.net is listed as author and that user has no ECA. I do not know if the ECA check is run only once (until it succeeds) and that is the reason why we did not got an error for that commit earlier in the old repo.

Maybe it is possibly for you to edit that commit so that it gets the same author as other commits

commit c3d38eb0b3a4ffe7c746218a5b3e22c4a7ce3ea1 (HEAD -> pr6)
Author: Walz <alwalz1@cmtclmlvxqr6x4k.rd.corpintra.net>
Date:   Tue Nov 7 15:30:34 2023 +0100

    Make flake8 happy :-)

    Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>

commit d3b05c6f55e54a2a4da11434be2e5413a0097c01
Author: Alexander Walz <alexander.walz@mercedes-benz.com>
Date:   Fri Nov 3 09:53:56 2023 +0100

    Adapt output message for reading the database file

    Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
    Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
andlaus commented 8 months ago

The eclipsefdn/eca check fails, in one of your commits alwalz1@cmtclmlvxqr6x4k.rd.corpintra.net is listed as author and that user has no ECA.

oops. git configuration error. fixed...

erikbosch commented 8 months ago

The remaining pre-commit error might be a false positive. I think I have seen a similar problem in another repo and will update dependencies and retry

andlaus commented 8 months ago

The remaining pre-commit error might be a false positive. I think I have seen a similar problem in another repo and will update dependencies and retry

yes, seems like flake8 does plays style police even within strings. (this is a bit weird IMO, even more so considering that the flake8 on my computer does not complain about it.) anyway, I've added a space before the x format...