search

eclipse-kuksa / kuksa-databroker

A modern in-vehicle VSS (Vehicle Signal Specification) server written in RUST
https://eclipse-kuksa.github.io/kuksa-website/
Apache License 2.0
12 stars 11 forks source link

Feature: continous subscription #16

Open lukasmittag opened 3 months ago

lukasmittag commented 3 months ago

https://github.com/eclipse/kuksa.val/pull/734

Behaviour:

lukasmittag commented 2 months ago

Okay, I see. I can understand. I wasn't aware of this since the PR of @rafaeling did the same.

rafaeling commented 2 months ago

Yes I did the same, I guess I forgot the goal of the PR and the issue context after some time. When I started working on this I remember to read this here https://github.com/eclipse/kuksa.val/issues/652#issuecomment-1717317496 since signal_type was not an inherent property I started with the approach of adding signal_type to VSS but after Comminity meeting it was decided to use better an optional parameter on the request to "decide implicitly" the type of signal/subscription (Change or Continuous). This PR I think implements a good feature but agree with that it does not really resolve the issue.