eclipse-kuksa / kuksa-databroker

A modern in-vehicle VSS (Vehicle Signal Specification) server written in RUST
https://eclipse-kuksa.github.io/kuksa-website/
Apache License 2.0
18 stars 17 forks source link

Upgrading codecov dependency #31

Closed erikbosch closed 4 months ago

erikbosch commented 4 months ago

Seems to be working. Well - upload does not work due to a limit for tokenless update, likely same problem as we often see for v3. Will do a retry tomorrow morning when it maybe is lower load as the Americans are sleeping.

It is MAYBE so that we could add a token to the fork, but we cannot expect that all forks have a suitable token, and it seems to imply that we enable codecov for that particular organization

error - 2024-05-13 14:46:53,425 -- Report creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 924 seconds."}

SebastianSchildt commented 4 months ago

Ok, just saw the error, but let me summarise what we see here

If we want more regular suceeding upload (and leave a bit of bandwidth for outside contributors), we could add a similarly named token to the orga we mostly do PRs from, and it would to tokenized upload

Anyway, as I have seen the repo idle for a bit, I will try manually retriggering the run, to see what happens when it can upload

Maybe in the long run, there might be a way, where the PR only generated Codevov input file and saves it as artefact, and we have another workflow running on something like

on:
  workflow_run:
    workflows: ["CodeCov prep"]  
    types:
      - completed

But anyway, no idea that is working, more of long term idea (this would need somehow to identify the run in question, find the artefact AND give Codecov all necessary meta data, so maybe not even possible)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.57%. Comparing base (e628c46) to head (0fa0eb8). Report is 17 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== - Coverage 48.61% 48.57% -0.05% ========================================== Files 31 31 Lines 10879 10866 -13 ========================================== - Hits 5289 5278 -11 + Misses 5590 5588 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erikbosch commented 4 months ago

@SebastianSchildt - what we possibly should follow up is what is reported as "base". In the image below it uses a quite old version (17 commits!) , possibly because it was that long time ago we last had a successful upload for main.

image