search

eclipse-kuksa / kuksa.val.feeders

kuksa.val.feeders
Apache License 2.0
8 stars 22 forks source link

Fraunhofer IEM - PS5 Formular 1 feeder #169

Closed DrySlime closed 7 months ago

DrySlime commented 8 months ago

Hello,

My Name is Christopher Seibel and I am a student working at Fraunhofer IEM. In my internship i had a the chance to write a simple provider, as a non-commercial research project, which takes the telemetrydata from the PS5 game "Formular 1" and feeds it to the KUKSA.val Databroker.

In the ReadMe you can also find a link to a Video of the final result. There we can see a visual representation of the data after it was sent to the Databroker.

This is my first time doing a pull request and I apologize for rookie mistakes, i am open for any feedback.

with kind regards, Christopher Seibel

SebastianSchildt commented 8 months ago

Hi Christopher, thank you for the PR. First step to get this in a good shape: The tests currently show, you have not "signed" the Eclipse Contributor approval. You did your commits with your Fraunhofer address, so basically what needs to be done is

FAQ: https://www.eclipse.org/legal/ecafaq.php

No costs :) and also not much legalese involved. basically the ECA roughly "by signing miy commits with my mail adress, I assure I created the code myself and/or have the right to provide it to Eclipse under the project license" (Apache-2.0 in our case)

wrt to testing, anyone in the team has a PS 5 :) ? @lukasmittag or @Chrylo maybe?

erikbosch commented 8 months ago

Thanks for your interest. We are about to deprecate/archive this repo and instead move items to the eclipse-kuksa organization on Github, but we consider your contribution as interesting to move to the new orga, so let us handle the PR here and move it afterwards.

Some hints on the other checks in Continuous Integration that fails

pre-commit

Python code must follow some flake8 rules. How you can setup pre-commit is described here. You can see what it complains on at the latest build: https://github.com/eclipse/kuksa.val.feeders/actions/runs/8082171646/job/22105089408?pr=169.

spdx

As of today we require that there shall be an spdx comment in each python file. Preferably also a copyright statement. The currently recommended approach is to have something like at top in this file so just add it to the top.

https://github.com/eclipse-kuksa/kuksa-can-provider/blob/main/dbcfeederlib/canreader.py

DrySlime commented 7 months ago

Hello again, I now had the time to try and fix the following problems: Spdx comments are now in the Python file. I created an Eclipse Account and signed the ECA My Code now follows the Flake8 rules.

Please feel free to point out further errors from my part.

lukasmittag commented 7 months ago

eca seems not to be signed. HAve you sued same email as specified in your github acccount?

DrySlime commented 7 months ago

Hey, I just double checked and i have used the same email and username

DrySlime commented 7 months ago

image

SebastianSchildt commented 7 months ago

I think README may only miss a newline at the end of the file. Not sure what is in the ini. To "force" pre-commit to check it, install it in the checked out folder as described here https://github.com/eclipse/kuksa.val.feeders, then "modify" both files (i.e. adding a sapce somehwere) do a git add, and then git commit. That will trigger the pre-commit hook to run locally and modifying the files. Then I think they can just be "git add" again, and then "git commit" . In doubt @erikbosch knows best

erikbosch commented 7 months ago

As suggested by Sebastian, do a local squash and if then rebase on latest master, and then a git force push, that should hopefully fix the ECA tickets.