eclipse-kura / kura

Eclipse Kura™ is a versatile framework to supercharge your edge devices, streamlining the process of configuring your gateway, connecting sensors, and IoT devices to seamlessly collect, process, and send data to the cloud.
https://eclipse.dev/kura/
Eclipse Public License 2.0
498 stars 306 forks source link

Unsaved changes dialog triggers incorrectly #2013

Closed ctron closed 4 years ago

ctron commented 6 years ago

While testing Kura 3.2 RC I noticed a few times that the "there are unsaved changes" dialog triggers incorrectly. Making a change, pressing "Apply" applies the changes, the "apply" button even gets disabled. Yet the Web UI asks to discard changes when moving away from the service.

MMaiero commented 6 years ago

Could you please provide a replicable set of actions in order to identify the issue?

ctron commented 6 years ago

I thought that would be clear by:

Making a change, pressing "Apply" applies the changes, the "apply" button even gets disabled. Yet the Web UI asks to discard changes when moving away from the service.

As this is an issue which sporadically appears (at least I haven't found a pattern yet) I cannot give you a set of instructions to replicate this with with 100% certainty.

tafitzgerald commented 4 years ago

I have seen this occur before as well and it happens irregularly. This is due to the field being marked as "dirty" when it is touched. This seems to be a minor bug in the system and will be corrected. Thanks for your input on this @ctron.

MMaiero commented 4 years ago

@tafitzgerald Any progress on this topic?

tafitzgerald commented 4 years ago

Should be finished. I'm waiting to test before creating PR.

tafitzgerald commented 4 years ago

Tested and submitted PR #2631