search

eclipse-langium / langium

Next-gen language engineering / DSL framework
https://langium.org/
MIT License
725 stars 65 forks source link

Update monaco-editor wrapper to latest version #1317

Closed kaisalmen closed 9 months ago

kaisalmen commented 9 months ago

This update monaco-editor wrapper to 3.5.0 and fixes the version of @codingame/monaco-vscode-api to 1.83.16 to prevent any minor version changes to break the compilation https://github.com/CodinGame/monaco-vscode-api/issues/291

kaisalmen commented 9 months ago

Was that a fresh workspacce without any old node_modules content? I need to reproduce this, first.

spoenemann commented 9 months ago

Yes, I started a new Gitpod workspace from the PR.

kaisalmen commented 9 months ago

Using npm run run in packages/generator-langium works. Executing npx yo langium somewhere else breaks it. 🤷‍♂️ I need to find out why. I have an idea, though.

kaisalmen commented 9 months ago

Interesting finding and the explanation why the two above cases differ: When you do this in the examples folder, the new project is considered part of the workspace and that kills the effect of overrides in the generated package.json now required for monaco-editor and vscode: image

I now explicitly named the projects (workspaces array) in the main package.json what actually fixes another problem. If you do npm i while having another example project like hello-world in the examples folder, the package-lock.json got polluted.

Btw, the order of entries in the workspaces array also defines the execution order.