search

eclipse-langium / langium

Next-gen language engineering / DSL framework
https://langium.org/
MIT License
725 stars 65 forks source link

declare minimal node engine version for development to be >= 18.0.0, upgrade vitest to '~1.0.0' #1319

Closed sailingKieler closed 9 months ago

sailingKieler commented 9 months ago

github workflow is already executed with node v18

sailingKieler commented 9 months ago

Is there anything else (documentation?) to be updated?

spoenemann commented 9 months ago

Is there anything else (documentation?) to be updated?

See #1277

sailingKieler commented 9 months ago

Is there anything else (documentation?) to be updated?

See #1277

I had that PR in mind, I updated the README within this change.

sailingKieler commented 9 months ago

It's quite a different PR now: Here're the updates as proposed in today's dev meeting.

kaisalmen commented 9 months ago

@sailingKieler sorry I wasn't able to participate in today's meeting. This seems to be a good compromise.

kaisalmen commented 9 months ago

@spoenemann I missed that, but have a solution for this. Either the base package.json must be of type module or the vite config file must have the ".mts" extension. We did the later one in sprotty.

sailingKieler commented 9 months ago

@spoenemann I missed that, but have a solution for this. Either the base package.json must be of type module or the vite config file must have the ".mts" extension. We did the later one in sprotty.

done!

@msujew can you have a look again?