search

eclipse-langium / langium

Next-gen language engineering / DSL framework
https://langium.org/
MIT License
665 stars 61 forks source link

fix: generate errors cause langium-cli to fail with exit code 2 #1437

Closed bjthehun closed 2 months ago

bjthehun commented 3 months ago

Resolves #1436:

When the generate command of langium-cli fails because of an error in a grammar/config file, it will return with exit code 2 and not report a "successful" finish.

This commit is expected to cause the CI pipeline to fail, because of the errors I introduced with #1401, which went unseen in the merge request.

msujew commented 3 months ago

Hey @bjthehun, thanks for the fix!

Can you also fix the original validation issue in a secondary commit in this PR? I don't really feel comfortable merging a failing pipeline into main.

bjthehun commented 3 months ago

Can you also fix the original validation issue in a secondary commit in this PR? I don't really feel comfortable merging a failing pipeline into main.

Secondary commit has been appended for further review.