eclipse-langium / langium

Next-gen language engineering / DSL framework
https://langium.org/
MIT License
663 stars 61 forks source link

make document symbol provider able to handle empty names #1565

Closed cdietrich closed 1 day ago

cdietrich commented 6 days ago

@msujew this is a corner case is our grammar where empty names are possible with string literals wdyt? alternative would be to move

name: name ?? nameNode.text,

or

{
            return [{
                kind: this.nodeKindProvider.getSymbolKind(astNode),
                kind: this.nodeKindProvider.getSymbolKind(astNode),
                name: name ?? nameNode.text,
                name: name === undefined || name.length === 0 ? nameNode.text : name,
                range: node.range,
                range: node.range,
                selectionRange: nameNode.range,
                selectionRange: nameNode.range,
                children: this.getChildSymbols(document, astNode)
                children: this.getChildSymbols(document, astNode)
            }

to a helper