eclipse-leda / leda-distro

Eclipse Leda provides a Yocto-based build setup for SDV.EDGE components
https://eclipse-leda.github.io/leda/
Apache License 2.0
14 stars 8 forks source link

multiple occurrences of sudo in run-leda.sh #54

Closed razr closed 1 year ago

razr commented 1 year ago

Describe the bug There are multiple occurrences of sudo in run-leda.sh which are undocumented. It is not transparent what this script is doing/could do with the machine after acquiring sudo privileges.

To Reproduce Steps to reproduce the behaviour:

$ grep sudo ./run-leda.sh
TUNCTL="sudo tunctl"
IFCONFIG="sudo ip"
IPTABLES="sudo iptables"
    sudo bash -c "echo 1 > /proc/sys/net/ipv4/ip_forward"
    sudo bash -c "echo 1 > /proc/sys/net/ipv4/conf/$TAP/proxy_arp"
        echo "Do you wish to install $package using sudo?"
                    sudo apt-get install -y $package;
sudo qemu-system-x86_64 \

Expected behaviour no sudo commands

Screenshots / Logfiles If applicable, add screenshots to help explain your problem.

Leda Version (please complete the following information):

Additional context no

mikehaller commented 1 year ago

We decided to remove all occurrences of sudo in the run-leda script and making it simpler.

If anybody wants to (or needs to) use a different type of network setup, a modification of the script is needed.