Replace remark-java - Githubissues

eclipse-lemminx / lemminx

XML Language Server

Eclipse Public License 2.0

272 stars 93 forks source link

Replace remark-java #1291

Open datho7561 opened 2 years ago

datho7561 commented 2 years ago

The fork of remark-java that we use has been archived by the maintainer. Look into alternative libraries to accomplish the same thing.

See:

https://github.com/eclipse/lemminx/pull/1288 (we need to update a library to address a security vulnerability, but updating the library breaks remark-java)
https://github.com/kotcrab/remark-java
https://github.com/eclipse/eclipse.jdt.ls/issues/2214

rgrunber commented 2 years ago

As you mentioned, we can't use flexmark-java because it requires a Java 11 runtime. Is there any chance we can upstream a fix to revert to Java 8 (at least in the html-to-markdown module) in addition to the jsoup version bump ? I got the impression they only started using Java 11 everywhere for fixing some test issues : https://github.com/vsch/flexmark-java/issues/494#issue-1127640636