Closed mgdlkundera closed 8 months ago
:x: Code is not well-formatted ! (more details)
Ensure your code build locally using:
mvn clean install
Or just validate code format with :
mvn formatter:validate
You can format the code with :
mvn formatter:format
See also How configure your IDE.
:information_source: Some tips :
If documentation or those automatic comments are not clear enough, please create a new issue to discus about how to enhance it.
(I edited the PR to target branch write_attributes
instead of master
)
I advice you to read specifications (see https://github.com/eclipse-leshan/leshan/issues/534#issue-341031759) (maybe this is already done :grin:)
I guess it should help to identify how attributes should interact with each other and so which kind of combination makes sense to test. :slightly_smiling_face:
(Also keep in mind that current implement doesn't probably implement expected behavior. So do not write tests in function of current code behavior :slightly_smiling_face:)
I rebase this work on writes_attributes
branch and it is now integrated in this branch.
(see PR #1514)
Following tests: