eclipse-leshan / leshan

Java Library for LWM2M
https://www.eclipse.org/leshan/
BSD 3-Clause "New" or "Revised" License
653 stars 408 forks source link

Integration tests write attributes #1587

Closed mgdlkundera closed 8 months ago

mgdlkundera commented 9 months ago

Following tests:

github-actions[bot] commented 9 months ago

:x: Code is not well-formatted ! (more details)

Ensure your code build locally using:

mvn clean install

Or just validate code format with :

mvn formatter:validate

You can format the code with :

mvn formatter:format

See also How configure your IDE.

github-actions[bot] commented 9 months ago

:information_source: Some tips :

If documentation or those automatic comments are not clear enough, please create a new issue to discus about how to enhance it.

github-actions[bot] commented 9 months ago

:x: Maven Build failed ! (more details)

Ensure your code build locally using:

mvn clean install
sbernard31 commented 9 months ago

(I edited the PR to target branch write_attributes instead of master)

sbernard31 commented 9 months ago

I advice you to read specifications (see https://github.com/eclipse-leshan/leshan/issues/534#issue-341031759) (maybe this is already done :grin:)

I guess it should help to identify how attributes should interact with each other and so which kind of combination makes sense to test. :slightly_smiling_face:

sbernard31 commented 9 months ago

(Also keep in mind that current implement doesn't probably implement expected behavior. So do not write tests in function of current code behavior :slightly_smiling_face:)

sbernard31 commented 8 months ago

I rebase this work on writes_attributes branch and it is now integrated in this branch.

sbernard31 commented 8 months ago

(see PR #1514)