eclipse-leshan / leshan

Java Library for LWM2M
https://www.eclipse.org/leshan/
BSD 3-Clause "New" or "Revised" License
653 stars 408 forks source link

Error when creating an unsuccessful ReadCompositeResponse #1674

Closed slaft closed 5 days ago

slaft commented 1 week ago

Version(s)

2.0.0-M17

Which components

server and client

Tested With

No response

What happened

This exception is thrown when the client/server tries to create an unsuccessful ReadCompositeResponse: IllegalArgumentException content OR timestampedValue should be not null

(Same for an ObserveCompositeResponse and CancelCompositeObservationResponse).

How to reproduce

No response

Relevant Output

No response

sbernard31 commented 5 days ago

This should be fixed by : https://github.com/eclipse-leshan/leshan/pull/1676

Let me know if this is easier for you to test if I integrate it directly in master ?

sbernard31 commented 5 days ago

Oops @JaroslawLegierski I just see that you also work on it : https://github.com/JaroslawLegierski/leshan/commit/7803d95125bb16bdb7b5fb8fe36332eb7d664f23

We should improve communication, let me know when you work on something :slightly_smiling_face:

slaft commented 5 days ago

Yes that's ok, thanks

sbernard31 commented 5 days ago

Yes that's ok, thanks

Just to be sure :slightly_smiling_face:

That's means :

  1. That's ok, I can test it without you to integrate it in master
  2. OR That's ok, I tested it and all tests pass now ?
slaft commented 5 days ago

Sorry my answer wasn't clear at all 🙂, I meant that all the tests pass now.

sbernard31 commented 5 days ago

Oh great thx :pray:

JaroslawLegierski commented 5 days ago

Oops @JaroslawLegierski I just see that you also work on it : JaroslawLegierski@7803d95

We should improve communication, let me know when you work on something 🙂

Sure, I should have informed you earlier. I prepared only the first proposal on how we can solve this problem, but you were faster. 😅 Currently I'm working on #1504.