search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

proposed documentation of error generation #561

Closed fredg1 closed 3 years ago

eclipse-lsp4j-bot commented 3 years ago

Can one of the admins verify this patch?

fredg1 commented 3 years ago

Seemed good.

fredg1 commented 3 years ago

One more change. I don't think null is a valid return value for a request processing method.

Right, I forgot that all return values have to be wrapped in CompletableFuture.completedFuture(<value>)

pisv commented 3 years ago

LGTM. But let us wait a bit and see if there are more comments.

@eclipse-lsp4j-bot ok to test