search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Update to Gradle 6 #572

Closed cdietrich closed 2 years ago

cdietrich commented 3 years ago

update to gradle 6.9.2 replace osgi with bnd pluin update to latest xtend gradle plugin use maven-publish instead of maven plugin

Signed-off-by: Christian Dietrich christian.dietrich@itemis.de

cdietrich commented 3 years ago

have no idea how to test this if new manifest are ok / comparable to old ones. maybe we should check in manifests instead of generating them.

i am also not sure how to replace the gradle maven plugin with the maven-publish plugin without breaking the upload stuff

cdietrich commented 2 years ago

anyone have an idea why the PR builds are not working whist the branch build is? something broken how patches are applied to main and tested?

jonahgraham commented 2 years ago

anyone have an idea why the PR builds are not working whist the branch build is? something broken how patches are applied to main and tested?

I missed this comment first time around - is the problem resolved?

cdietrich commented 2 years ago

@jonahgraham no as you can see Jenkins PR Build is red but continuous-integration/jenkins/branch is green

https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/cd_bmpXtendGradlePlugin/14/ https://ci.eclipse.org/lsp4j/job/lsp4j-github-pullrequests/253/

ice1000 commented 2 years ago

Gradle 7.5.1 is released, are we going to update to Gradle 7?

cdietrich commented 2 years ago

I would like to do it in two steps but first we need to do this one and I have no clue how to verify it

ice1000 commented 2 years ago

The ci fails with

04:36:01 FAILURE: Build failed with an exception.
 04:36:01
 04:36:01 * What went wrong: 
04:36:01 Task 'createLocalMavenRepo' not found in root project 'lsp4j'.
 04:36:01 
04:36:01 * Try: 
04:36:01 Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
 04:36:01 
04:36:01 * Get more help at https://help.gradle.org 
04:36:01 
04:36:01 BUILD FAILED in 17s
cdietrich commented 2 years ago

The problem is that the ci executes the old build with the new changes (In Jenkinsfile) So my new jenkinsfile is not picked

cdietrich commented 2 years ago

how shall we continue here

jonahgraham commented 2 years ago

how shall we continue here

Technical question or otherwise.

If it is ready and acceptable we should merge it and update the PR job so future checks don't fail https://github.com/eclipse/lsp4j/pull/572#discussion_r784045066

cdietrich commented 2 years ago

I am still not sure if everything is still working as intended. Have no clue eg how to test if jars and poms are comparable

jonahgraham commented 2 years ago

I'll try to review that - i.e. by manually looking at the before and after generated jars/poms.

jonahgraham commented 2 years ago

These are the differences I see:

All of these changes look ok to me, so based on the output I think we are good to go.

cdietrich commented 2 years ago

will give a look if some of the diffs can be addressed by configuring the plugins differently

cdietrich commented 2 years ago

i can see Import-Package org.eclipse.lsp4j.jsonrpc.messages;version= "[0.16,1)" in the new variant too.

cdietrich commented 2 years ago

ok, can you formally approve, then we can merge and i can test with snapshot consuming in Xtext