search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Allow more versions of gson? #611

Closed frankbenoit closed 2 years ago

frankbenoit commented 2 years ago

Currently only exactly gson 2.8.9 is allowed. Would it be possible to allow a wider range? if the semantic versioning is valid, even [2.8.9,3.0) should be ok. This would simplify the coexistence with other bundles that have dependencies to gson.

jonahgraham commented 2 years ago

Hi @frankbenoit, that sounds reasonable. Please can you provide a patch?

cdietrich commented 2 years ago

https://github.com/eclipse/lsp4j/blob/32ad52691b2fcaef7011ffc6461641f1164dc1f2/gradle/versions.gradle#L19 isnt this one used for manifest too?

frankbenoit commented 2 years ago

Yes, but this is exactly 1 version. After 2.8.9 they released 2.9.0

cdietrich commented 2 years ago

and were there some breaking changes or do they do sem. versioning?

frankbenoit commented 2 years ago

The minimum supported Java version changes from 6 to 7. https://github.com/google/gson/releases/tag/gson-parent-2.9.0

nixel2007 commented 2 years ago

and were there some breaking changes or do they do sem. versioning?

Google? semver and no breaking changes? Ha! They can break backward compatibility in a patch release.

cdietrich commented 2 years ago

we will go with [2.9.0,2.10) for now