search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Late updates for LSP 3.17 #630

Closed KamasamaK closed 2 years ago

KamasamaK commented 2 years ago

These are the changes to the LSP 3.17 specification that were added after it was published as done.

jonahgraham commented 2 years ago

We can spin up a 0.14.0 release if needed in short order, please let me know with a comment on #628

cdietrich commented 2 years ago

i assume a 0.13.1 would be better for p2 consumers as maven consumers a rebuild would be needed anway

jonahgraham commented 2 years ago

i assume a 0.13.1 would be better for p2 consumers as maven consumers a rebuild would be needed anway

I advise against it because there are API changes in this commit - 0.13.0 and 0.13.1 are not interchangeable due to new fields and the changed super type hierarchy. I could be convinced otherwise though if you think it is unlikely enough for anyone to hit that problem in practice, especially as we are still officially incubating.

cdietrich commented 2 years ago

Yes. The question is when it would be available. I planned to do a Xtext release on Monday

jonahgraham commented 2 years ago

@cdietrich I can release very quick once it is merged as I just went through the cycle of that a few days ago. Can you or @KamasamaK or someone else approve and merge?