search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Another late addition for LSP 3.17 #635

Closed KamasamaK closed 2 years ago

KamasamaK commented 2 years ago

Added WorkspaceSymbol.data

jonahgraham commented 2 years ago

Is there an urgent need to roll this out? Or can it wait? It is frustrating that a "final" spec keeps changing. I can see the new field was added in the typescipt code 7 months ago: https://github.com/microsoft/vscode-languageserver-node/blame/1fe84c5b656d9db07f812cb573d2c0d82f9d8366/client/src/common/protocolWorkspaceSymbol.ts#L11

Either way I think this should be updated:

https://github.com/eclipse/lsp4j/blob/95c0ed6c90192e2a8ab12b1ccb2e142eef476b15/README.md?plain=1#L38-L41

KamasamaK commented 2 years ago

I agree. These should have probably been 3.17.1 or something like that. I don't feel it's urgent, but I didn't think the previous additions were either.

Either way, I will try to look into Notebook support soon so that the next release is more worthwhile.

jonahgraham commented 2 years ago

I agree. These should have probably been 3.17.1 or something like that. I don't feel it's urgent, but I didn't think the previous additions were either.

For the previous ones we had just released and I wanted to get (What I had hoped) was the real final 3.17.0 into the 2022-06 SimRel release.

Either way, I will try to look into Notebook support soon so that the next release is more worthwhile.

Great.