search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Update Javadoc of Variable#type #637

Closed gquerret closed 2 years ago

gquerret commented 2 years ago

The Variable#type javadoc does not seem correct to me. I've changed the documentation to match the DAP specification

eclipse-lsp4j-bot commented 2 years ago

Can one of the admins verify this patch?

gquerret commented 2 years ago

Still trying to find why my ECA is not recognized.

jonahgraham commented 2 years ago

@eclipse-lsp4j-bot run tests

jonahgraham commented 2 years ago

Still trying to find why my ECA is not recognized.

I tried a manual check on your email address (from the commit) and was told the same thing: There is no valid ECA on file for [...]

Please visit https://accounts.eclipse.org/user/eca to sign & check your ECA. If that still doesn't work, please contact the Eclipse Foundation via license@eclipse.org.

You may also have multiple accounts, so that may need resolving too - https://accounts.eclipse.org/search/profile/Gilles%20QUERRET - Raise a ticket if needed here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/new - one of those accounts has a valid ECA - https://accounts.eclipse.org/users/gquerreta2m - but the other two don't.

HTH.

gquerret commented 2 years ago

I've opened a ticket, as I'm not able to regain access to the gquerret account.

jonahgraham commented 2 years ago

Great - I'll following along on that issue in case I can do anything more to help.

jonahgraham commented 2 years ago

Thanks @gquerret for persisting in sorting out the ECA issues. I hope that now we have been through this once you will find it smoother and faster to make PRs in the future.

gquerret commented 2 years ago

All in all, it wasn't very difficult and got very good help from the Eclipse team. I'll open new PR if I find anything worth a modification !