search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

javax.websocket #647

Open cdietrich opened 2 years ago

cdietrich commented 2 years ago

build uses javax.websocket from orbit, which is no longer available in newer orbit versions. we might have to use a newer orbit version for a newer gson eventually.

=> how to resolve? is jakarta.websocket a feasible alternative? so that we can drop the javax one?

or do we need to restore javax.websocket on orbit

pisv commented 2 years ago

=> how to resolve? is jakarta.websocket a feasible alternative? so that we can drop the javax one?

I don't think so, see #536. Could not we just stick to the last available javax.websocket from Orbit?

cdietrich commented 2 years ago

I think we can, just makes the target file more complicated / less straight forward

jonahgraham commented 8 months ago

The long term plan could be to remove the org.eclipse.lsp4j.websocket bundle (as was tried and reverted in #536)

I don't know how to do that in the short term without causing problems to people such as @mitasov-ra who may still be on it.

But since javax.websocket isn't being developed anymore I recommend the first step is to deprecate org.eclipse.lsp4j.websocket and no longer include it in the SDK and SimRel so that it is only available to those that need it by going directly to the maven coordinates for it, or to the LSP4J p2 repo.

If we don't hear any further complaint or request for maintenance on it, we can delete it in a couple of years.

jonahgraham commented 8 months ago

first step is to deprecate

Done in #803