search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Support new DAP `startDebugging` request #662

Closed mickaelistria closed 1 year ago

mickaelistria commented 2 years ago

See https://github.com/microsoft/debug-adapter-protocol/issues/79 and https://github.com/microsoft/debug-adapter-protocol/pull/326

KamasamaK commented 2 years ago

That request was removed from the spec for now, so I've removed it from #663 and I don't think it will make LSP4J v0.16.

See microsoft/debug-adapter-protocol#334

mickaelistria commented 1 year ago

@KamasamaK Coming back to this topic, are you aware of any external blocker before we can add support for startDebugging in LSP4J DAP support?

mickaelistria commented 1 year ago

Submitted https://github.com/eclipse/lsp4j/pull/704 that hopefully does the job as expected...

jonahgraham commented 1 year ago

Fixed in #704 (with the rest of DAP 1.60.0 in #716)