search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Update to Gradle 7.5 and xtend-gradle-plugin 3.0.2 #667

Closed cdietrich closed 2 years ago

cdietrich commented 2 years ago

Update to Gradle 7.5 and xtend-gradle-plugin 3.0.2 Added missing resources.prefs

cdietrich commented 2 years ago

@jonahgraham the PR build still seems to execute createLocalMavenRepo where is this one defined?

cdietrich commented 2 years ago

it seems to be in the config, edited it. lets see

cdietrich commented 2 years ago

would be nice, yes

jonahgraham commented 2 years ago

would be nice, yes

I have just noticed you merged this. Do you still need a review, or are you satisfied with the change?

cdietrich commented 2 years ago

I assume it works but if you still can do a diff it would be nice.

jonahgraham commented 2 years ago

The diff looks basically identical to me. I think that makes sense as even though version of Gradle changed, version of Bnd stayed the same. I compared build output of build 63 vs build 64