search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Fix type adapter for `workspace/diagnostic` response #683

Closed pisv closed 1 year ago

pisv commented 1 year ago

Fixes #682

pisv commented 1 year ago

Build failed with [ERROR] Failed to resolve target definition /home/jenkins/agent/workspace/lsp4j-github-pullrequests/releng/releng-target/lsp4j.target.target: Could not find "com.google.guava/30.1.0.v20210127-2300" in the repositories of the current location. I've provided a separate PR #684 to fix it.

pisv commented 1 year ago

Everything seems to be OK now. The PR is ready for review.

pisv commented 1 year ago

@jonahgraham Thanks for your review and approval! If there are no objections, I'm going to merge it tomorrow morning (European time).

jonahgraham commented 1 year ago

@jonahgraham Thanks for your review and approval! If there are no objections, I'm going to merge it tomorrow morning (European time).

Perfect - works for me as I will probably do releng afternoon Ottawa time.