search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
613 stars 145 forks source link

Add support for startDebugging #704

Closed mickaelistria closed 1 year ago

eclipse-lsp4j-bot commented 1 year ago

Can one of the admins verify this patch?

jonahgraham commented 1 year ago

@eclipse-lsp4j-bot run tests

jonahgraham commented 1 year ago

@eclipse-lsp4j-bot run tests

cdietrich commented 1 year ago

@eclipse-lsp4j-bot run tests

cdietrich commented 1 year ago

build currently does not run cause auf nexus.eclipse outage https://ci.eclipse.org/lsp4j/job/lsp4j-github-pullrequests/407/console

jonahgraham commented 1 year ago

@eclipse-lsp4j-bot run tests

jonahgraham commented 1 year ago

I had hoped to get to this by now, but alas too many other things to review. Still hoping that @KamasamaK may swoop in and review, but I should get to it soon if he doesn't.

mickaelistria commented 1 year ago

@jonahgraham no big issue; I don't have strong needs for it on short term; of course -like all reviews- the sooner the better, but as I'm also busy with other things, I don't plan to get to LSP4E side of things shortly, so this can wait without harming.

mickaelistria commented 1 year ago

@jonahgraham sure, thanks a lot!

jonahgraham commented 1 year ago

The rest of the updates to bring the DAP part of LSP4J up to date are in #716