Use Java 11

[mickaelistria]

Fixes #547

[eclipse-lsp4j-bot]

Can one of the admins verify this patch?

[cdietrich]

@eclipse-lsp4j-bot run tests

[jonahgraham]

Note that this change needs CI updates too as CI uses Java 8.

[cdietrich]

https://github.com/eclipse/lsp4j/blob/4bad511eb9471bef9aafc9ad8e7d9c55b6747a25/releng/build.Jenkinsfile#L10 https://github.com/eclipse/lsp4j/blob/4bad511eb9471bef9aafc9ad8e7d9c55b6747a25/releng/release-eclipse.Jenkinsfile#L10 maybe more

[cdietrich]

@eclipse-lsp4j-bot run tests

[jonahgraham]

@eclipse-lsp4j-bot run tests

That won't work as the PR job doesn't use Jenkinsfile. Landing #706 first may help here.

[cdietrich]

@jonahgraham as our pr build do this "run on top thing" is there any way to test this besides pushing it as real branch?

[cdietrich]

pushed to https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/mickaelistria-java-11/

[jonahgraham]

pushed to https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/mickaelistria-java-11/

That is a good solution. Alternatively change the JDK in the PR job now.

[cdietrich]

https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/mickaelistria-java-11/ is green @jonahgraham are you ok with the pr?

[szarnekow]

No description provided.

@mickaelistria can you please explain the problem you're going to solve here from an lsp4j maintainers point of view? If I understand it correctly, this change will only make the next release incompatible to Java8 without any other user observable modifications?

[mickaelistria]

On #705 , I was encouraged to switch to Java 11 by @jonahgraham who referred to #547 . Supporting less versions is naturally reducing the target/scope of the project and thus reducing the amount of combination that are supposedly supported, thus decreasing the support cost; moving to newer versions enables to use newer feature languages which are most often more powerful or less error-prone, allow to keep the code more modern and more appealing to new contributors. The real question is not "why" but "why not"? Is anyone in LSP4J committer really gaining anything with Java 8 support? If there is no value generated by this constraint, why not getting rid of it?

[jonahgraham]

@eclipse-lsp4j-bot run tests

[szarnekow]

@mickaelistria A link in the commit message would have rendered my question obsolete, I guess.

[jonahgraham]

@mickaelistria A link in the commit message would have rendered my question obsolete, I guess.

I added the missing "Fixes..."

[jonahgraham]

@eclipse-lsp4j-bot run tests

[ice1000]

Coool!!