eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
599 stars 143 forks source link

Run workflow on Windows, macOS and Linux #736

Closed jonahgraham closed 1 year ago

jonahgraham commented 1 year ago

This is to provide a test bench for #734 and to help prevent any fix for #734 from regressing.

cdietrich commented 1 year ago

@jonahgraham can you check if my patch works with that?

nixel2007 commented 1 year ago

You could add macos too, cause it may have some os-specific behavior in uri and path handling (and yes, lsp4j is used on macos setups as part of bsl language server)

jonahgraham commented 1 year ago

@jonahgraham can you check if my patch works with that?

I am looking at that now - I couldn't get your patch to work, but #737 has an alternative I am trying to verify.

You could add macos too, cause it may has some os-specific behavior in uri and path handling (and yes, lsp4j is used on macos setups as part of bsl language server)

OK, will do.