search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
582 stars 141 forks source link

Update to guava 33.0.0.jre #782

Closed merks closed 6 months ago

merks commented 6 months ago

@cdietrich @jonahgraham

Could someone approve the build?

This change is analogous to the following:

https://github.com/eclipse-lsp4j/lsp4j/commit/523168fb44987087e638ecbfa6640c9f963a774e

jonahgraham commented 6 months ago

For 2024-03 M1 I think we should just widen the version and do a patch (0.21.2) release like #759 and we can plan on doing an full LSP4J release (0.22.0) in coordination with other projects (like LSP4E and xtext) otherwise we substitute duplicate guava for duplicate lsp4j.

I will start working on that now, let me know if you have objections.

cdietrich commented 6 months ago

plus one from me. then we can release Xtext with the 0.21.2 dependency in case there wont be a release in lsp4j for 2024-03 and lsp4j can then consume the Xtext 2.34 release