Add `reason` field to Breakpoint

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.

https://eclipse.org/lsp4j

Other

581 stars 141 forks source link

Add `reason` field to Breakpoint #825

Closed Soarex16 closed 3 months ago

Soarex16 commented 3 months ago

According to the specification, the Breakpoint type must have reason optional field. This field was introduced in microsoft/debug-adapter-protocol#437.

jonahgraham commented 3 months ago

Thanks for the submission. reason was added in 1.64 and LSP4J has only implemented up until 1.60 so far.

I'm therefore not sure what to do with this pull request. Hopefully someone can implement 1.61-1.64 (or 65) so I don't need to decide how to handle this special case.

Would you like to submit a PR to upgrade to 1.64 or 1.65?

Soarex16 commented 3 months ago

Yes, I would like to prepare PR with an upgrade to the latest version. Then this one should be included in it. Thank you!

jonahgraham commented 3 months ago

That is great @Soarex16 - I look forward to reviewing it when you are ready.