search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
608 stars 144 forks source link

Update DAP protocol up to 1.65 #827

Closed Soarex16 closed 5 months ago

Soarex16 commented 5 months ago

@jonahgraham I combined all updates into one PR.

jonahgraham commented 5 months ago

Thanks - all in one PR, but with one commit per DAP version is very helpful and should make it easier for me to review.

@KamasamaK can you have a look too - is this still in your wheelhouse?

Soarex16 commented 5 months ago

I updated the schema version, but didn't touch other things because I don't want to interfere with the release processes.

Soarex16 commented 5 months ago

@jonahgraham yes, I missed memoryReference in SetExpressionResponse. I checked the changelog again and everything should be fine now.

Thank you!

jonahgraham commented 5 months ago

Thank you @Soarex16 for the contribution.

I have merged and kicked off the build. It should end up in snapshots in a little while.

If you want a released version, please comment on #807 any constraints/timelines you have.

KamasamaK commented 5 months ago

I've finally been able to review this and found a few minor issues and one big issue that I'll address in another PR.