search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
581 stars 141 forks source link

Fix frameId type in DataBreakpointInfoArguments #829

Closed Soarex16 closed 2 months ago

Soarex16 commented 2 months ago

According to spec frameId in DataBreakpointInfoArguments should be optional.

KamasamaK commented 2 months ago

You're right. It should also have the standard "This is an optional property." added too.

Soarex16 commented 2 months ago

@KamasamaK done

KamasamaK commented 2 months ago

@Soarex16 There appears to be a spacing issue on one of the lines. Ensure you're using a tab to indent.

Soarex16 commented 2 months ago

My bad, thanks for your attention!