search

eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.
https://eclipse.org/lsp4j
Other
581 stars 141 forks source link

broaden gson range, bundle new gson and guava #837

Closed cdietrich closed 1 month ago

cdietrich commented 1 month ago

@jonahgraham do we need a dot release for simrel?

szarnekow commented 1 month ago

As a client of lsp4j I'd even consider using a 3.0 as the exclusive upper bound of the dependency.

jonahgraham commented 1 month ago

As a client of lsp4j I'd even consider using a 3.0 as the exclusive upper bound of the dependency.

We got (minorly) burned a while ago because a new version of gson didn't strictly follow semantic versioning. Ever since then I have been concerned to not have a runtime problem.

However I am asked multiple times for this, so seeing as many consumers seem ok with the (minor) risk, I say lets widen it up.

@jonahgraham do we need a dot release for simrel?

Yes

cdietrich commented 1 month ago

Can you merge am afk