Closed jadelkhoury closed 5 years ago
Now regarding your questions.
OAuth related code is under https://github.com/OSLC/lyo-samples/blob/master/oauth-cli-helper/src/main/java/org/eclipse/lyo/client/oauth/sample/OAuthClient.java I have no idea why the artifactId
is not the same, I tried to ensure I only rename folders not IDs.
oslc4j-client-samples
are not migrated because this is a "new" repo that @jamsden created to have a set of matching samples for the new version of the Lyo Client. We might also want to move it to the samples repo outside Lyo, but that's up to you and @jamsden.
Ok. I thought this was a simple delete I thought I can help with. But if the code has diverged, I'd rather someone else that was involved (you? @jamsden) take care of it.
Sure. But thanks for getting the process going, Jad!
-- /Andrew (from phone)
On Mon, Apr 8, 2019 at 10:52 PM +0200, "Jad El-khoury" notifications@github.com<mailto:notifications@github.com> wrote:
Ok. I thought this was a simple delete I thought I can help with. But if the code has diverged, I'd rather someone else that was involved (you? @jamsdenhttps://github.com/jamsden) take care of it.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/eclipse/lyo.client/pull/42#issuecomment-481003264, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAD83qRpWEOVquZLiSQGVu7MNUFu0WX7ks5ve6vsgaJpZM4cga4G.
Submitted new PRs
2 issues remain: