Closed berezovskyi closed 2 years ago
@berezovskyi Should we merge this change? Did you test it?
Yes I did, yes we should.
But I forgot how changes to this repo get pushed to LyoD.
This is how it looks in the resulting generated code. Are the file names of the javascript & stylesheets different? If not, then nothing to change.
That is, will your changes still produce the same file names under https://github.com/OSLC/lyo-adaptor-sample-modelling/tree/main-5.x/adaptor-rm-webapp/src/main/webapp/static/dist/oslc-ui
Ok, let’s try to merge this PR and update one of the oslc servers. For the record, the screenshots above ARE from me testing the changes on one of the servers. I just don’t recall how LyoD is involved in it. But I guess it’s not involved much and one copies files to dist manually?
Do you need any help with this?
I have not given it a go yet really. So, leave it to me for now.
@berezovskyi I'll just squash and merge so we can close this branch.
Angular supports only one major version upgrade at a time. Subsequent PRs will upgrade the project until we reach a supported version of Angular.
As part of the upgrade, I updated the version of ng-bootstrap, and switched most of the styling to use CSS Flex, the "new" CSS layout model which doesn't require many old tricks with floats. New look:
And in the sample client:
I think larger padding and removal of extra borders will look better.
I also replaced internal URIs to the SES*** OSLC server with the one towards the OSLC RefImpl, which is openly available.
I envision the notice in the bottom left to be customizable so that the server could render the text like: