eclipse-lyo / lyo.oslc-ui

Eclipse Public License 2.0
3 stars 7 forks source link

Upgrade to Angular 10 and refresh design #13

Closed berezovskyi closed 2 years ago

berezovskyi commented 2 years ago

Angular supports only one major version upgrade at a time. Subsequent PRs will upgrade the project until we reach a supported version of Angular.

As part of the upgrade, I updated the version of ng-bootstrap, and switched most of the styling to use CSS Flex, the "new" CSS layout model which doesn't require many old tricks with floats. New look:

Screen Shot 2022-05-14 at 17 50 13

And in the sample client:

Screen Shot 2022-05-14 at 17 50 42

I think larger padding and removal of extra borders will look better.

I also replaced internal URIs to the SES*** OSLC server with the one towards the OSLC RefImpl, which is openly available.

I envision the notice in the bottom left to be customizable so that the server could render the text like:

Requirement Selection Dialog (RefImpl RM 2020; generated by Eclipse Lyo)

jadelkhoury commented 2 years ago

@berezovskyi Should we merge this change? Did you test it?

berezovskyi commented 2 years ago

Yes I did, yes we should.

berezovskyi commented 2 years ago

But I forgot how changes to this repo get pushed to LyoD.

jadelkhoury commented 2 years ago

This is how it looks in the resulting generated code. Are the file names of the javascript & stylesheets different? If not, then nothing to change.

https://github.com/OSLC/lyo-adaptor-sample-modelling/blob/main-5.x/adaptor-rm-webapp/src/main/webapp/com/sample/rm/uipreview.jsp

That is, will your changes still produce the same file names under https://github.com/OSLC/lyo-adaptor-sample-modelling/tree/main-5.x/adaptor-rm-webapp/src/main/webapp/static/dist/oslc-ui

berezovskyi commented 2 years ago

Ok, let’s try to merge this PR and update one of the oslc servers. For the record, the screenshots above ARE from me testing the changes on one of the servers. I just don’t recall how LyoD is involved in it. But I guess it’s not involved much and one copies files to dist manually?

berezovskyi commented 2 years ago

Do you need any help with this?

jadelkhoury commented 2 years ago

I have not given it a go yet really. So, leave it to me for now.

jadelkhoury commented 2 years ago

@berezovskyi I'll just squash and merge so we can close this branch.