search

eclipse-lyo / lyo.oslc-ui

Eclipse Public License 2.0
3 stars 7 forks source link

If possible, download the binaries as a prep step in CI #2

Open berezovskyi opened 4 years ago

berezovskyi commented 4 years ago

It would be good to remove binaries from https://github.com/eclipse/lyo.oslc-ui/tree/master/libs/jsonschema2pojo-1.0.2

jadelkhoury commented 4 years ago

Alternatively, the POJOs are produced locally as part of the development work. They don't need to be integrated into the build. With such an approach, we just need to add "Developer Instructions" on the wiki of this repo (or the readme.md).

How to use

After cloning this git repository

  1. download and install jsonschema2pojo
    1. Download the 1.0.2 release (jsonschema2pojo-1.0.2.zip) from https://github.com/joelittlejohn/jsonschema2pojo/releases
    2. Unzip into the folder oslc-ui\libs\. (that is, under the path oslc-ui\libs\jsonschema2pojo-1.0.2, there should be bin & lib folders)
  2. Go the root folder of the repo.
  3. run npm run build:elements-prod...
berezovskyi commented 4 years ago

I’d try to avoid hacky approaches of possible.

-- Cheers, Andrew

From: Jad El-khoury notifications@github.com Sent: Tuesday, October 27, 2020 10:55:15 PM To: eclipse/lyo.oslc-ui lyo.oslc-ui@noreply.github.com Cc: Andrew Berezovskyi andrew@berezovskyi.me; Author author@noreply.github.com Subject: Re: [eclipse/lyo.oslc-ui] If possible, download the binaries as a prep step in CI (#2)

Alternatively, the POJOs are produced locally as part of the development work. They don't need to be integrated into the build. With such an approach, we just need to add "Developer Instructions" on the wiki of this repo (or the readme.md).

How to use

After cloning this git repository

  1. download and install jsonschema2pojo
  2. Go the root folder of the repo.
  3. run npm run build:elements-prod...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/eclipse/lyo.oslc-ui/issues/2#issuecomment-717563079, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAPZXT3SY4AMZJRNJNQFNDSM46UHANCNFSM4TBMVY5Q.

jadelkhoury commented 4 years ago

Can we make a decision on this? Why is this hacky I am not sure. Producing the POJOs is something one does rarely, and I see it as part of the development work.

berezovskyi commented 4 years ago

I think what is hacky is that you (a) copy POJOs that change rarely, which is a good candidate for maven release; (b) copy the same files to many servers, causing duplication and multiplying efforts when updates are needed; (c) because you copy random files, you don't properly version them.

In the rest of the javaland, people use maven packages to solve all three of these.

On 4 November 2020, at 08:59, Jad El-khoury notifications@github.com wrote:

Can we make a decision on this? Why is this hacky I am not sure. Producing the POJOs is something one does rarely, and I see it as part of the development work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/lyo.oslc-ui/issues/2#issuecomment-721573641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPZXW35NGJ26EQJWCJC6DSOECWLANCNFSM4TBMVY5Q.

berezovskyi commented 4 years ago

CC @AndreyBespamyatnov in case you are still planning to contribute to the repo beyond the initial push.

jadelkhoury commented 4 years ago

That we agree on. But that is covered under the other issue https://github.com/eclipse/lyo.oslc-ui/issues/3

The original description of this issue is about not committing the jsonschema2pojo library. The library is used to produce the POJOs. So, I still think we should

  1. NOT commit jsonschema2pojo.
  2. Manually produce the POJOs.
  3. CI to produce a maven out of hte POJOS (https://github.com/eclipse/lyo.oslc-ui/issues/3)
berezovskyi commented 4 years ago

All right, that sounds like a plan! Sorry for confusing the issue, replying via email over limited connection.

On 4 November 2020, at 13:00, Jad El-khoury notifications@github.com wrote:

That we agree on. But that is covered under the other issue #3 https://github.com/eclipse/lyo.oslc-ui/issues/3 The original description of this issue is about not committing the jsonschema2pojo library. The library is used to produce the POJOs. So, I still think we should

NOT commit jsonschema2pojo. Manually produce the POJOs. CI to produce a maven out of hte POJOS (#3 https://github.com/eclipse/lyo.oslc-ui/issues/3) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/lyo.oslc-ui/issues/2#issuecomment-721690996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPZXR2NOHNDYGBATOBZCLSOE655ANCNFSM4TBMVY5Q.