feat: handle multiple ResponseInfo obj in Query response

eclipse-lyo / lyo

Eclipse Lyo, a Java SDK for OSLC-based tool integration

https://oslc.github.io/developing-oslc-applications/eclipse_lyo/eclipse-lyo.html

Eclipse Public License 2.0

17 stars 17 forks source link

feat: handle multiple ResponseInfo obj in Query response #606

Closed berezovskyi closed 1 week ago

berezovskyi commented 2 months ago

Description

Allows Query responses to be paged even in presence of multiple ResponseInfo objects.

Checklist

[x] This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
[x] This PR was tested on at least one Lyo OSLC server (e.g. manual workflow on Lyo Sample and OSLC RefImpl) or adds unit/integration tests.
[x] This PR does NOT break the API

Issues

Closes #605

See:

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 30%)

See analysis details on SonarCloud

berezovskyi commented 1 month ago

Also fixed in https://github.com/OSLC/oslc4net/pull/203

berezovskyi commented 2 weeks ago

@Jad-el-khoury @anamrosu please approve the PR if you think we are ready to merge and release this as SNAPSHOT

Jad-el-khoury commented 1 week ago

The logic looks ok to me, assuming it is tested. I think we should raise this issue to the OP, since the specs makes the response quite unstable.

berezovskyi commented 1 week ago

@Jad-el-khoury thanks, there is a unit test inside using a real OSLC query response I got from IBM CLM Nordic instance we have access to.

@anamrosu please check if 7.0.0-SNAPSHOT works for you as expected. If not, please comment/reopen #605 and we will investigate further.

anamrosu commented 1 week ago

I tested just now and for us it works well.

berezovskyi commented 1 week ago

@anamrosu great to hear!

The release of Lyo 7 is tied to the upgrade to Jena 5. We are on Jena 4 now and no versions below Jena 5 are receiving security updates any more. If we get any help with it, we can release it sooner. We have a PR open to upgrade to Jena 4.10 that needs testing and then we can do the remaining updates needed for Jena 5. #389

I can maybe release a 7.0.0-alpha1 for you if it will help you and if I can find some time to do it. @Jad-el-khoury what do you think about doing an alpha for this patch and Jena 4.10?

anamrosu commented 1 week ago

Hi @berezovskyi, an Alpha version would be helpful, thanks!

berezovskyi commented 3 days ago

@anamrosu https://forum.open-services.net/t/new-versions-of-lyo-and-oslc4net-released/839 there are two alphas for you to try