eclipse-lyo#636 Add option to not add providers by default

eclipse-lyo / lyo

Eclipse Lyo, a Java SDK for OSLC-based tool integration

https://oslc.github.io/developing-oslc-applications/eclipse_lyo/eclipse-lyo.html

Eclipse Public License 2.0

17 stars 17 forks source link

eclipse-lyo#636 Add option to not add providers by default #637

Closed jhemm2 closed 4 weeks ago

jhemm2 commented 1 month ago

Description

Adds another Constructor the OslcClient to allow custom registration of providers for the Client. This is due to registration of deprecated json providers by default

Checklist

[x ] This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt. (Minor)
[ ] This PR was tested on at least one Lyo OSLC server (e.g. manual workflow on Lyo Sample and OSLC RefImpl) or adds unit/integration tests.
[ x] This PR does NOT break the API

Issues

Closes #636 ;

(use exactly this syntax to link to issues, one issue per statement only!)

jhemm2 commented 1 month ago

I made a proposal commit and removed the deprecated dependency. Furthermore, I have refactored the OslcClient to avoid duplicate code and added some unit-tests accordingly. Hth

Jad-el-khoury commented 4 weeks ago

The original change to control the Providers looks good. But noticed other refactoring that I could not review. Are you happy with them @berezovskyi then I am fine.

but @jhemm2 ! Please fix the unintended changes. I am afraid we will endup with many back-forth changes due to diffferent IDE settings.

berezovskyi commented 4 weeks ago

Yes, I am fine with the changes.

Reformatting the code touched by the PR is intentional and welcomed/required.

With regards to the settings, there is sn .editorconfig file in the repo that everyone (cough) is expected to apply when reformatting.

But I have two further ideas on my bucket list:

add checkstyle to enforce more than just indentation and line limits.
do a big bang reformat of the whole codebase - but it will break all pull requests.

berezovskyi commented 4 weeks ago

Two more bits:

it would be good @jhemm2 if you could commit (in the future) code changes and reformat as different commits - same PR. Ideally, one commit at the start and one at the end, but not a strict rule.
@Jad-el-khoury please configure https://github.com/ncjones/editorconfig-eclipse#installation on your machine - as is described in our CONTRIBUTING.md in bold: https://github.com/eclipse-lyo/lyo/blob/master/CONTRIBUTING.md#contributing-to-eclipse-lyo

Jad-el-khoury commented 4 weeks ago

@berezovskyi editorconfig seems to be in place, but not sure if it makes a difference. go ahead then @jhemm2 !

Jad-el-khoury commented 4 weeks ago

can @jhemm2 commit to master, or should we do it?

berezovskyi commented 4 weeks ago

@Jad-el-khoury not unless @jhemm2 becomes a committer ;)