eclipse-m2e / m2e-core

Eclipse Public License 2.0
112 stars 114 forks source link

POM Editor (Lemminx-based) uses large font-size for hover information about plugin configuration parameter #477

Open kwin opened 2 years ago

kwin commented 2 years ago

In contrast to the WTP-based POM editor

WTP-based-pom-editor-hover

the Lemminx-based POM editor uses a large font for the hover window

Lemminx-based-pom-editor-hover

In addition the latter shows each parameter three times (probably once for each mojo) which should be deduplicated for the global plugin configuration.

kwin commented 2 years ago

One more suggestion regarding the order: For the plugin parameter the description is in most of the cases the most relevant one, i.e. should be displayed on top. The other metadata should only follow afterwards (i.e. below the description).

mickaelistria commented 2 years ago

Can you please make suggestion about the content of the assistance to https://github.com/eclipse/lemminx-maven/issues ? Note that the multiple parameters is more a m2e issue, which could be caused by the language server actually being started 3 times instead of 1 as expected.

HannesWell commented 2 years ago

Note that the multiple parameters is more a m2e issue, which could be caused by the language server actually being started 3 times instead of 1 as expected.

I just encountered duplicated proposals too. But only some are duplicated (some two times, some three times), so it is another problem: grafik

kwin commented 2 years ago

Can you please make suggestion about the content of the assistance to https://github.com/eclipse/lemminx-maven/issues ?

Done in https://github.com/eclipse/lemminx-maven/issues/239

mickaelistria commented 2 years ago

@kwin If you upgrade to latest m2e snapshots, your fix in lemminx-maven should now have some effect.

laeubi commented 2 years ago

Could this be closed then?

kwin commented 2 years ago

All issues mentioned in https://github.com/eclipse-m2e/m2e-core/issues/477#issue-1092746402 are not yet fixed (and the font size needs to be fixed in m2e core and not sure not in lemminx)