search

eclipse-mat / mat

The Eclipse Memory Analyzer is a fast and feature-rich Java heap dump analyzer that helps you find memory leaks and reduce memory consumption.
https://eclipse.dev/mat/
Eclipse Public License 2.0
35 stars 8 forks source link

CI Build warnings #39

Open eclipsewebmaster opened 2 months ago

eclipsewebmaster commented 2 months ago

| --- | --- | | Bugzilla Link | 582473 | | Status | ASSIGNED | | Importance | P3 minor | | Reported | Sep 26, 2023 11:11 EDT | | Modified | Oct 30, 2023 05:31 EDT | | Version | 1.14 | | Reporter | Andrew Johnson |

Description

There are some warning which come out of CI builds which it would be nice to fix.\ The build is Tycho / Maven running run by Jenkins.

Examine the full console log from a build: https://ci.eclipse.org/mat/job/tycho-mat-nightly/

[INFO] ---------------------------[ eclipse-plugin ]---------------------------\ [WARNING] Parameter 'ignoreTychoRepositories' is unknown for plugin 'target-platform-configuration:2.7.5:target-platform (default-target-platform)'

[javadoc] Creating destination directory: "/home/jenkins/agent/workspace/tycho-mat-nightly/plugins/org.eclipse.mat.ui.help/doc/"\ [javadoc] warning: URL https://docs.oracle.com/javase/8/docs/api/element-list was redirected to https://docs.oracle.com/en/java/javase/21/ -- Update the command-line options to suppress this warning.\ \ It might be better to link to the Java 11 documentation\ https://docs.oracle.com/en/java/javase/11/docs/api/index.html

eclipsewebmaster commented 2 months ago

By Krum Tsvetkov on Sep 27, 2023 04:23

I can have a look at these, as I am currently looking at the build.

I see that Tycho is already a v.4.0.2 while we are using 2.7.5. I'll create a separate bug for moving to a new tycho, but would probably do it only after the release - at least in the past I often had to adapt things on our side after bigger version jumps.

eclipsewebmaster commented 2 months ago

By Andrew Johnson on Sep 27, 2023 04:44

The Javadoc warning might be harmless - I think the MAT -> JDK Javadoc links do work.\ Javadoc looks for package-list and for later versions of Java, element-list.

I think this needs to be present for the remote Javadoc for the Javadoc links to be built properly.

https://docs.oracle.com/javase/8/docs/api/package-list\ https://docs.oracle.com/javase/9/docs/api/package-list\ https://docs.oracle.com/en/java/javase/10/docs/api/element-list < missing\ https://docs.oracle.com/en/java/javase/11/docs/api/element-list < missing\ https://docs.oracle.com/en/java/javase/17/docs/api/element-list\ https://docs.oracle.com/en/java/javase/21/docs/api/element-list

We wouldn't want to link to a non-LTS release (9,10 etc.)

Does MAT provide package-list or element-list for consumers?

eclipsewebmaster commented 2 months ago

By Krum Tsvetkov on Sep 27, 2023 05:08

Oops, I have to admit I don't understand how we build the javadoc parts. Sorry.

For the other warning about 'ignoreTychoRepositories' - I can't find it int the documentation and it is marked as unknown also in the IDE. I just tried building with and without it and I end up with successful builds and exactly the same set of plugins (with exception of the mat plugins generated by the build) in the RCPs.\ I think it is safe to remove it and will merge a change for it.

eclipsewebmaster commented 2 months ago

By Andrew Johnson on Oct 02, 2023 10:07

There were also these messages near the end of the build.\ I don't know whether they are important or not.

[WARNING] \ [WARNING] Plugin validation issues were detected in 19 plugin(s)\ [WARNING] \ [WARNING] org.eclipse.tycho:tycho-p2-repository-plugin:2.7.5\ [WARNING] org.apache.maven.plugins:maven-site-plugin:3.12.1\ [WARNING] org.eclipse.tycho:tycho-p2-publisher-plugin:2.7.5\ [WARNING] org.eclipse.cbi.maven.plugins:eclipse-dmg-packager:1.3.1\ [WARNING] org.eclipse.cbi.maven.plugins:eclipse-jarsigner-plugin:1.3.1\ [WARNING] org.apache.maven.plugins:maven-surefire-plugin:2.22.2\ [WARNING] org.apache.maven.plugins:maven-failsafe-plugin:2.22.2\ [WARNING] org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3\ [WARNING] org.apache.maven.plugins:maven-deploy-plugin:2.8.2\ [WARNING] org.eclipse.tycho:tycho-ds-plugin:2.7.5\ [WARNING] org.eclipse.cbi.maven.plugins:eclipse-macsigner-plugin:1.3.1\ [WARNING] org.apache.maven.plugins:maven-install-plugin:2.3.1\ [WARNING] org.eclipse.tycho:tycho-surefire-plugin:2.7.5\ [WARNING] org.eclipse.cbi.maven.plugins:eclipse-winsigner-plugin:1.3.1\ [WARNING] org.codehaus.mojo:wagon-maven-plugin:2.0.0\ [WARNING] org.apache.maven.plugins:maven-antrun-plugin:1.7\ [WARNING] org.eclipse.tycho:tycho-packaging-plugin:2.7.5\ [WARNING] org.eclipse.tycho:tycho-compiler-plugin:2.7.5\ [WARNING] * org.apache.maven.plugins:maven-resources-plugin:2.4.1\ [WARNING] \ [WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]\ [WARNING]

eclipsewebmaster commented 2 months ago

By Andrew Johnson on Oct 30, 2023 05:31

I've tidied up some of the Javadoc build warnings:

https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/205208\ https://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=0fd443834cdb6f021fca539fc09753083d5b73c4

The plugin validation messages in bug 582473 comment 4 went away in build https://ci.eclipse.org/mat/job/tycho-mat-nightly/1491/console