eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

org.eclipse.modisco.infrastructure.feature : missing provider name #1023

Closed eclipse-modisco-bot closed 3 days ago

eclipse-modisco-bot commented 3 days ago

| --- | --- | | Bugzilla Link | 517365 | | Status | RESOLVED FIXED | | Importance | P1 normal | | Reported | May 29, 2017 08:13 EDT | | Modified | May 30, 2017 11:23 EDT | | Version | 0.13.0 | | Blocks | 517315 | | See also | Gerrit change https://git.eclipse.org/r/98128, Git commit 91ed4ee5, Gerrit change https://git.eclipse.org/r/98181, Git commit 39d78452 | | Reporter | Gregoire Dupe |

Description

According to https://hudson.eclipse.org/simrel/job/simrel.oxygen.runaggregator.BUILD__CLEAN/lastSuccessfulBuild/artifact/aggregation/final/buildInfo/reporeports/reports/providerNames.html some provider name are missing.

org.eclipse.modisco.infrastructure.feature.feature.group 1.1.0.201705151331 \ null\ org.eclipse.modisco.infrastructure.feature.feature.jar 1.1.0.201705151331 \ null\ org.eclipse.modisco.infrastructure.source.feature.group 1.1.0.201705151331 \ null\ org.eclipse.modisco.infrastructure.source.feature.jar 1.1.0.201705151331 \ null

eclipse-modisco-bot commented 3 days ago

May 29, 2017 08:19

New Gerrit change created: https://git.eclipse.org/r/98128

eclipse-modisco-bot commented 3 days ago

By Gregoire Dupe on May 29, 2017 09:54

I require to push this fix into the RC2 build : this path (1 line) fix the missing provider name.

eclipse-modisco-bot commented 3 days ago

May 29, 2017 10:10

Gerrit change https://git.eclipse.org/r/98128 was merged to [master].\ Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=91ed4ee53f6c468e1be6a74b07b3799b5a3ebb6a

eclipse-modisco-bot commented 3 days ago

By Gregoire Dupe on May 30, 2017 03:47

This bug has been fixed, build, and delivered into Oxygen RC2.

Waiting a new build of https://hudson.eclipse.org/simrel/job/simrel.oxygen.runaggregator.BUILD__CLEAN/ to close this bug.

eclipse-modisco-bot commented 3 days ago

By Andreas Sewe on May 30, 2017 03:53

(In reply to Eclipse Genie from comment #3)

Gerrit change https://git.eclipse.org/r/98128 was merged to [master]. Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/ ?id=91ed4ee53f6c468e1be6a74b07b3799b5a3ebb6a

Looking at the fix, it occurs to me that the feature/@label attribute should probably reference the %featureName defined in the features.properties [1].

Hope this helps.

[1] http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/tree/org.eclipse.modisco.infrastructure.feature/feature.properties?id=91ed4ee53f6c468e1be6a74b07b3799b5a3ebb6a#n26

eclipse-modisco-bot commented 3 days ago

By Gregoire Dupe on May 30, 2017 03:55

Looking at the fix, it occurs to me that the feature/@label attribute should probably reference the %featureName defined in the features.properties [1].

Hope this helps.

[1] http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/tree/org.eclipse. modisco.infrastructure.feature/feature. properties?id=91ed4ee53f6c468e1be6a74b07b3799b5a3ebb6a#n26

Ok thanks, I'll fixed that too.

eclipse-modisco-bot commented 3 days ago

May 30, 2017 03:57

New Gerrit change created: https://git.eclipse.org/r/98181

eclipse-modisco-bot commented 3 days ago

May 30, 2017 05:08

Gerrit change https://git.eclipse.org/r/98181 was merged to [master].\ Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=39d7845206d191a8f7b0cc03ae542dcf64d12046

eclipse-modisco-bot commented 3 days ago

By Gregoire Dupe on May 30, 2017 11:23

This bug has been fixed, build, and delivered into Oxygen RC2 (1.1.0.201705300912).

Waiting a new build of https://hudson.eclipse.org/simrel/job/simrel.oxygen.runaggregator.BUILD__CLEAN/ to close this bug.