eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

Bad org.eclipse.emf.ecore.generated_package registration in org.eclipse.modisco.utils.chart.metamodel #1033

Closed eclipse-modisco-bot closed 3 days ago

eclipse-modisco-bot commented 3 days ago

| --- | --- | | Bugzilla Link | 552871 | | Status | RESOLVED FIXED | | Importance | P3 critical | | Reported | Nov 09, 2019 05:10 EDT | | Modified | Feb 17, 2020 11:12 EDT | | See also | 544165, 552870 | | Reporter | Ed Willink |

Description

CRITICAL since installing Modisco can break a non-Modisco aplication.

The Manifest editor clearly shows two warnings in /org.eclipse.modisco.utils.chart.metamodel/plugin.xml

a) the package should be ...metamodel.internal.chart.ChartPackage rather than ...metamodel.chart.chartPackage"

b) the genmodel should be model/chart.genmodel rather than model/birtChart.genmodel

The bad class spelling causes a ClassNotFoundException for any application that traverses the globalEPackage registry. Such applications should catch an exception per traversal entry, but many do not, so that their traversal terminates prematurely when Modisco's bad entry is traversed;the application either fails completely or only sees a partial EPackage registry.

As well as being very evident in the Manifest editor and problems view, this bug also causes Modisco tests to fail, so there is a lesser research query as to how this bug has escaped fixing.

eclipse-modisco-bot commented 3 days ago

By Ed Willink on Nov 25, 2019 08:41

Fix pushed to master for 2019-12M3.

eclipse-modisco-bot commented 3 days ago

By Fabien Giquel on Feb 17, 2020 11:12

Bug 498420 has been marked as a duplicate of this bug.