Maintain CDO currency

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 553130 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Nov 17, 2019 05:07 EDT | | Modified | Nov 25, 2019 08:31 EDT | | Blocks | 552988 | | See also | 302693, 553375 | | Reporter | Ed Willink |

Description

The Modisco build currently uses the Derby database adapter which is not in SimRel. See Bug 302693 and while the omission could be remedied, Eike recommends migrating from Derby to H2 since H2 is in SimREl and the preferred CDO interface.

Modisco's use of CDO is presumably fairly trivial; do a search all in a CDO-space rather than a filespace. Migrating should be easy.

[eclipse-modisco-bot]

By Ed Willink on Nov 21, 2019 07:53

org.eclipse.modisco.java.discoverer.benchmark.RunBenchmark has tests for both CDO+H2 and CDO+Derby so clearly H2 support is already present.

It looks as if it may be sufficient to make Derby support an optional dependency. The actual reference in

@Override\
protected IDBAdapter getDBAdapter() {\
    return new EmbeddedDerbyAdapter();\
}

can be changed to a reflective Class.forName with a helpful how-to-install exception.

[eclipse-modisco-bot]

By Eike Stepper on Nov 21, 2019 09:58

Sounds good ;-)

[eclipse-modisco-bot]

By Ed Willink on Nov 22, 2019 16:45

The Derby support is in a separate loose feature that is not part of the SDK feature contributed to SimRel. Therefor no SimRel prblem at all.

Making Derby optional in a feature specifcally to install Derby would therefore be perverse.

Just need to help a user who is installing from the full MoDisco repo to find the CDO repo. Time to find out if the extra URLs in feature.xml do this.

[eclipse-modisco-bot]

By Ed Willink on Nov 23, 2019 04:44

(In reply to Ed Willink from comment #3)

Just need to help a user who is installing from the full MoDisco repo to find the CDO repo. Time to find out if the extra URLs in feature.xml do this.

No. May be they work post-install; pre-install both documentation URL and sites to visit are useless.

All we can do is put a site recommendation in the Feature Description.

[eclipse-modisco-bot]

By Ed Willink on Nov 25, 2019 08:31

(In reply to Ed Willink from comment #4)

All we can do is put a site recommendation in the Feature Description.

No. There's nothing wrong with the normal policy once you think it through.

The MoDisco P2 repo contains a large feature that is contributed and transitively copied by SimRel.

The Modisco update site contains an add-on feature that is not contributed and so not copied by SimRel. The add-on feature includes all non-SimRel plugins to avoid any install problems provided "Contact All Sites" enables SimRel.

It is a shame/surprising that we have to make a CDO plugin plus sources available this way, but it should just work without bloating SimRel.

Consistent build pushed to master for 2019-12M3.