org.eclipse.modisco.usecase.modelfilter.tests.SimpleBlackBoxDiscovery.testUmlModelFromJavaProjectWithReferenceModel fails

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 580945 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Oct 23, 2022 04:18 EDT | | Modified | Nov 21, 2022 11:10 EDT | | See also | 580946 | | Reporter | Ed Willink |

Description

The regular weekly rebuild has now twice failed on

org.eclipse.modisco.usecase.modelfilter.tests.SimpleBlackBoxDiscovery.testUmlModelFromJavaProjectWithReferenceModel

due to a model comparison failure whose size exceeds the log, so no clues.

[eclipse-modisco-bot]

By Ed Willink on Oct 23, 2022 04:58

Attempting a local build hits Bug 580946 so try another CDO version.

[eclipse-modisco-bot]

By Ed Willink on Nov 09, 2022 06:43

(In reply to Ed Willink from comment #1)

Attempting a local build hits Bug 580946 so try another CDO version.

CDO bug fixed, no difference; still fails on Jenkins but passes locally.

Setting up a workspace and 'magically' a similar failure appears in the JUnit Plugin test of org.eclipse.modisco.usecase.modelfilter.tests.AllTestsInUIThread

Problem appears to be unstable ordering of children. It seems that Class is now sorted before Interface. Partial log on Jenkins seems to tell the same story.

[eclipse-modisco-bot]

By Ed Willink on Nov 09, 2022 07:26

(In reply to Ed Willink from comment #2)

Problem appears to be unstable ordering of children.

UML's Package.packagedElement is not ordered so there is no need for the ordering to match. The use of EmfFormatter toString only works if ordered (or if normalized as OCL Pivot tests do.).

Oops. TestModelUtils.compareModels has been an UnsupportedOperationException since 2012.

I used an EmfFormatter clone to implement it in 2020.

So just need to normalize / disable test again.

[eclipse-modisco-bot]

By Ed Willink on Nov 21, 2022 11:10

(In reply to Ed Willink from comment #3)

So just need to normalize / disable test again.

The UML model is installed so the PIvot test normlizers can be much simplified for MoDisco.

All ok. Pushed to master.