eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

Accommodate java.lang.constant #1068

Closed eclipse-modisco-bot closed 3 days ago

eclipse-modisco-bot commented 3 days ago

| --- | --- | | Bugzilla Link | 582651 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Nov 20, 2023 04:58 EDT | | Modified | Nov 20, 2023 06:43 EDT | | See also | 582650 | | Reporter | Ed Willink |

Description

Java 12 introduces a number of @since 12 classes to the java.lang.constant package. Other classes in the package have no @since but seem secondary, so we may suspect that the ntire package is new in Java 12.

Since/associated with the builds moving from Java 11 to Java 17 the org.eclipse.modisco.usecase.modelfilter.tests.SimpleBlackBoxDiscovery.testUmlModelFromJavaProjectWithReferenceModel test has been failing.

Examining the JUnit comparison suggests that there are extra external entries associated with java.lang.constant.

Hardly surprising that extra Java could result in extra Java discovery; perhaps more surprising that only one test fails. However comments within the test suggest that it went to special efforts to check content rather than just smoke.

'modelfilter' suggests that there might be filtering options that should perhaps be augmented / fixed to accommodate java.lang.constant. But none are obviously configured in the test. The chnaged output has extra constant interfaces and sub-package; all eminently reasonable, so let's just provide a chnaged reference.

eclipse-modisco-bot commented 3 days ago

By Ed Willink on Nov 20, 2023 06:43

pushed to master for RC1