search

eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

[releng] Resolve org.eclipse.emf.query issues #1078

Closed eclipse-modisco-bot closed 2 days ago

eclipse-modisco-bot commented 2 days ago

| --- | --- | | Bugzilla Link | 583470 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Jul 07, 2024 08:21 EDT | | Modified | Jul 08, 2024 09:28 EDT | | Reporter | Ed Willink |

Description

org.eclipse.emf.query has not build since 2022 and has left SimRel.

Latest builds use 2018 explicitly for nightly and SimRel for milestone. milestone therefore now fails.

Change to use 2022 explicitly for borth until such time as org.eclipse.emf.query suffers fatal bit rot.

eclipse-modisco-bot commented 2 days ago

By Ed Willink on Jul 07, 2024 08:34

If org.eclipse.emf.query is not in the latest SimRel users are going to get an installation failure until they add an older SimREl or EMF Query to the known update sites.

Do we rediustribute org.eclipse.emf.query?

Can we add an old SimRel to the known sites? Would that cause confusion?

Can we add the old org.eclipse.emf.query to the known update sites?

Do we remove the org.eclipse.emf.query dependencies?

eclipse-modisco-bot commented 2 days ago

By Ed Willink on Jul 07, 2024 10:49

(In reply to Ed Willink from comment #1)

Do we remove the org.eclipse.emf.query dependencies?

Seems to be used only from org.eclipse.modisco.infra.query.tests and then only in EmfmqQueryTest invoked from /org.eclipse.modisco.infra.query.tests/src/org/eclipse/modisco/infra/query/tests/UnitTests.java and marked as @Ignore pending resolution of Bug 552989.

Seems like we lose nothing for now by just deleting the dependency.

A rewrite of the 5 lines of EMF Query commands using OCL should be easy.

Yes, but no transitively org.eclipse.emf.transaction needs org.eclipse.emf.query and org.eclipse.modisco.facet.util.emf.core and org.eclipse.modisco.util.emf.core use org.eclipse.emf.transaction.

This is only a problem for the nightly built that has hardwired 2018 dependencies. Moving on to 2022/2023 and we benefit from the transitive fix. (Pity that there is no latest.)

Pushed to master. Build ready for 1.5.5M1 once Jenkins gets some TLC.

eclipse-modisco-bot commented 2 days ago

By Ed Willink on Jul 08, 2024 09:28

Contributed to SimRel for 2024-09 M1.