[MoDisco Browser] MoDisco browser to an editor

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 304362 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Mar 02, 2010 09:54 EDT | | Modified | Sep 22, 2010 05:35 EDT | | Version | 0.8.0 | | Blocks | 304011 | | Reporter | Nicolas Payneau |

Description

Build Identifier: 20100204-1618

Hi MoDisco team,

In order to occupy my long winter nights, I transformed the MoDisco browser to an editor. In attachment, the patch for this.

In this patch:

• I modified the EcoreBrowser class

• I changed PropertySheetPage to ExtendedPropertySheetPage.

• We didn't use PropertySourceAdapterFactory but AdapterFactoryContentProvider to fuel the PropertySheetPage.

• EcoreBrowser class implements IEditingDomainProvider and IGotoMarker

• I implemented methods save saveAs isDirty ... (They were not implemented)

• I modified the BrowserActionBarContributor class

• BrowserActionBarContributor class extends EditingDomainActionBarContributor

• I added "New Child" and "New Sibling" menus

• I added a default menu to provide eclipse with delete, copy, undo, redo, ... functions

• I modified the WorkspaceChangeListener class

• I modified the Messages class and Messages.properties file.

So with this patch the following actions become available:

• Edit a model
• Add an object to the model
• Delete an object from the model
• Undo, redo, refresh

To finish, with the MoDisco browser we can see details of a selected "AttributeItem" in the property view. Now, we only show the details of containing "ModelElementItem" when we select an "AttributeItem" .

Best regards,

Nicolas Payneau

Reproducible: Always

[eclipse-modisco-bot]

By Nicolas Payneau on Mar 02, 2010 09:56

Created attachment 160623 Patch transforming the MoDisco browser to an editor

:notepad_spiral: org.eclipse.gmt.modisco.infra.browser.patch

[eclipse-modisco-bot]

By Nicolas Payneau on Mar 04, 2010 09:05

(In reply to comment #1)

Created an attachment (id=160623) [details] Patch transforming the MoDisco browser to an editor

Hi,

I discovered an error after the patch contributed. This error appears in some cases when selecting item in the browser.\ This error located in the class org.eclipse.gmt.modisco.infra.browser.editors.BrowserActionBarContributor at line 231.\ We have to check if the object has a resource before retrieving the URI.

Best regards,

Nicolas Payneau

[eclipse-modisco-bot]

By Hugo Bruneliere on Mar 10, 2010 11:14

Hi Nicolas,

Please, could you make the usual confirmations via this bug and attach to it the latest version of the patch to be actually integrated?

I will create the corresponding CQ as soon as possible.

Best regards,

Hugo

[eclipse-modisco-bot]

By Nicolas Payneau on Mar 10, 2010 12:23

(In reply to comment #3)

Hi Nicolas,

Please, could you make the usual confirmations via this bug and attach to it the latest version of the patch to be actually integrated?

I will create the corresponding CQ as soon as possible.

Best regards,

Hugo

Hi Hugo,

I confirm that you have the latest version of the patch. \ I confirm that

1. I, Nicolas Payneau, authored 100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Best regards,

Nicolas

[eclipse-modisco-bot]

By Hugo Bruneliere on Mar 11, 2010 09:07

Corresponding CQ 3845 has been created.

[eclipse-modisco-bot]

By Hugo Bruneliere on Mar 11, 2010 10:56

The CQ has been validated (very quickly thanks to Sharon).\ I'm going to integrate the patch.

Hugo

[eclipse-modisco-bot]

By Hugo Bruneliere on Mar 11, 2010 11:59

Nicolas,

I have some problems applying your patch: e.g. it removes the PropertySourceAdapterFactory class which is still required, etc.\ Note that I'm using the latest version of the org.eclipse.gmt.modisco.infra.browser plug-in (sources) from the MoDisco SVN trunk.

Please, could you check from your development workspace that you don't have such issues?

Regards,

Hugo

[eclipse-modisco-bot]

By Nicolas Bros on Mar 11, 2010 12:14

Don't bother with it. Gabriel made a refactoring, and I already made modifications to the patch. So, leave it to me.

[eclipse-modisco-bot]

By Hugo Bruneliere on Mar 12, 2010 04:33

OK Nicolas.\ So I consider the patch as being applied.

Hugo