JSP Metamodel : CharacterDataElement is useless

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 320107 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Jul 16, 2010 09:49 EDT | | Modified | Oct 18, 2010 08:33 EDT | | Version | 0.9.0 | | Reporter | Fabien Giquel |

Description

JSPComment may inherit directly from Node, as Comment.\ JavaScript does not need to inherit from CharacterDataElement.

-> CharacterDataElement should be deleted.\ The JSP discoverers and generator should be modified in consequence.

[eclipse-modisco-bot]

By Nicolas Guyomar on Jul 16, 2010 10:08

Hi Fabien,

Please find attached the corresponding modification, those impact the following projects :

org.eclipse.gmt.modisco.jee.jsp \ org.eclipse.gmt.modisco.jee.jsp.discoverer \ org.eclipse.gmt.modisco.jee.jsp.discoverer.tests \ org.eclipse.gmt.modisco.jee.jsp.generation \ org.eclipse.gmt.modisco.jee.jsp.generation.tests

Even if we are dealing with a minor modification in the Ecore, this results in quite a big patch because of the regeneration of the Metamodel implementation as well as the regeneration of the MoDisco JSP Lexer/Parser

1. I, Nicolas Guyomar, and others contributors listed in this bug, authored\ 100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards

Nicolas

[eclipse-modisco-bot]

By Nicolas Guyomar on Jul 16, 2010 10:09

Created attachment 174493 Removes CharacterDataElement from MoDisco JSP Meta Model

:notepad_spiral: patchCharacterDataElement.txt

[eclipse-modisco-bot]

By Fabien Giquel on Jul 16, 2010 10:33

Frederic,

here is a contribution from an employee of Mia-Software. The company has signed\ a Member Commiter Agreement.

It is possible to commit this work without the need of a CQ, with the\ confirmation that this work is done under PMC supervision.

Is it possible for you, or someone else of modeling PMC, to approve this work ?\ Such a contribution deals with Java technologies reverse engineering. This\ theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project\ plan).

Thanks in advance.

[eclipse-modisco-bot]

By Fabien Giquel on Jul 22, 2010 13:23

Kenn,

here is a contribution from an employee of Mia-Software. The company has signed\ a Member Commiter Agreement.

It is possible to commit this work without the need of a CQ (as Sharon\ confirmed it in older CQ\ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3846#c9), with the\ confirmation that this work is done under PMC supervision.

Is it possible for you, or someone else of modeling PMC, to approve this work ?\ Such a contribution deals with Java/JEE technologies reverse engineering. This\ theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project\ plan).\ I will describe more precisely the proposed enhancement if you wish.

Thanks in advance.

[eclipse-modisco-bot]

By Fabien Giquel on Jul 23, 2010 05:47

Thanks for your contribution Nicolas,\ thanks for your quick approval Kenn.

The code has been commited into SVN.

[eclipse-modisco-bot]

By Hugo Bruneliere on Oct 05, 2010 04:20

The patch has been successfully applied.