eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

[Model Browser] Management of broken references #451

Closed eclipse-modisco-bot closed 2 hours ago

eclipse-modisco-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 321487 | | Status | CLOSED FIXED | | Importance | P3 enhancement | | Reported | Aug 02, 2010 05:52 EDT | | Modified | Oct 18, 2010 08:35 EDT | | Version | 0.9.0 | | Reporter | Nicolas Guyomar |

Description

Hi,

There should be more than a red customization to indicate that a resource is missing while browsing a model in the MoDisco Model Browser.

The red customization could be used by anyone for another purpose, and because clicking on the resource does not raise any flag, it seems to me that the "missing resource" information is not clear enough.

There could be a message in the MoDisco Logger, or an error message such as the "Reflective Ecore Model Editor" one.

As a enhancement, would it be possible to know if the whole resource (xmi file) is missing, or if it is just a model element ?

Regards

Nicolas

eclipse-modisco-bot commented 2 hours ago

By Nicolas Bros on Sep 13, 2010 09:46

Actually, an EObject appearing in red means that this EObject has a null eResource(). This is normal in the case of some EObjects, like instances of EFactory for example. So, this is not by itself reason enough for an error message.

would it be possible to know if the whole resource (xmi file) is missing, or if it is just a model element?

since the resource is null in this case, I don't believe that's possible

Maybe what you want is for the model browser to be able to validate the model, and report validation errors like the sample reflective Ecore editor?

eclipse-modisco-bot commented 2 hours ago

By Nicolas Bros on Sep 13, 2010 12:21

In revision 3025, I replaced hardcoded color customizations:

eclipse-modisco-bot commented 2 hours ago

By Nicolas Bros on Sep 14, 2010 10:41

I am marking this bug as fixed, since I fixed the potential clash between the hard-coded customizations and the user-defined customizations. Please open a separate bug if you need model validation.

eclipse-modisco-bot commented 2 hours ago

By Hugo Bruneliere on Oct 05, 2010 04:28

Bug fixed.