eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

NPE in ModiscoURIHandler#canHandle #499

Closed eclipse-modisco-bot closed 3 hours ago

eclipse-modisco-bot commented 3 hours ago

| --- | --- | | Bugzilla Link | 325085 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Sep 13, 2010 04:54 EDT | | Modified | May 23, 2011 09:27 EDT | | Version | 0.8.0 | | Reporter | Nicolas Bros |

Description

Created attachment 178721\ stacktrace

See attached stacktrace.

:notepad_spiral: stacktrace.txt

eclipse-modisco-bot commented 3 hours ago

By Nicolas Bros on Sep 13, 2010 04:58

Created attachment 178722 project to reproduce the error

To reproduce:

You should get the NPE.

:compression: Bug325085.zip

eclipse-modisco-bot commented 3 hours ago

By Nicolas Bros on Sep 13, 2010 05:10

Created attachment 178723 patch

Here is a patch that trivially fixes the NPE.

:notepad_spiral: Bug 325085.patch

eclipse-modisco-bot commented 3 hours ago

By Nicolas Bros on Sep 13, 2010 05:42

The problem is due to the fact that I set just "my" as the nsURI of the FacetSet in my example. So, the nsURI doesn't have a scheme.

I think this patch can be applied for RC4, since it's trivial and the NPE can easily happen if the user wasn't careful to set a correctly formed nsURI on his FacetSets.

eclipse-modisco-bot commented 3 hours ago

By Nicolas Bros on Sep 13, 2010 09:50

I applied the patch to branch 0.8 in revision 3023.

eclipse-modisco-bot commented 3 hours ago

By Hugo Bruneliere on Oct 05, 2010 05:06

The patch has been successfully applied.