eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

JSP discoverer : duplicate scriptlet content leads to unnecessary memory usage #549

Closed eclipse-modisco-bot closed 2 hours ago

eclipse-modisco-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 327565 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Oct 12, 2010 10:55 EDT | | Modified | Oct 21, 2010 05:03 EDT | | Version | 0.9.0 | | Reporter | Fabien Giquel |

Description

Parsing some JSP with JSP scriptlet leads to JSPScriptlet instances where content is both attached to the "name" attribute and a child Text instance.

The content should be contained only on child Text instance.

eclipse-modisco-bot commented 2 hours ago

By Nicolas Guyomar on Oct 12, 2010 12:04

Created attachment 180685 JSP discoverer memory usage improvment

Hi Fabien,

In order to reduce the memory usage the MoDisco Jsp Discoverer does no longer store a name for the JSPScript (Sriptlet, Expression and Declaration)

In order to keep the visualization in the model browser intact I created a query to complete the existing uiCustomization for MoDisco JSP Models.

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution (b) I have the right to contribute the code to Eclipse (c) I want to contribute this code under EPL

Regards

Nicolas Guyomar

:notepad_spiral: bug327565.patch

eclipse-modisco-bot commented 2 hours ago

By Fabien Giquel on Oct 14, 2010 03:47

The contribution is less than 250 lines.\ It has been commited into SVN (rev 3323)

Fabien.

eclipse-modisco-bot commented 2 hours ago

By Hugo Bruneliere on Oct 21, 2010 05:03

The patch has been successfully integrated.